-
Notifications
You must be signed in to change notification settings - Fork 24
Update translations #285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update translations #285
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## wip-version-6 #285 +/- ##
===================================================
+ Coverage 52.53% 52.66% +0.13%
Complexity 1463 1463
===================================================
Files 140 140
Lines 6358 6361 +3
===================================================
+ Hits 3340 3350 +10
+ Misses 3018 3011 -7 ☔ View full report in Codecov by Sentry. |
|
I'm not sure this is a good idea.. The Dutch translations were pretty bad.. Some technical phrases are better left in English because they just don't translate well. |
|
Thanks for the input, I was afraid of that... So this presents maintenance burden, and also I don't really know which translation is ok and which is not ok... If I leave only old translations (and fallback to en for new ones), only like 10 % will be actually translated... So, I'm better of removing those languages totally. If someone wants them, we can add them at any time. |
|
Nah, we just gotta ask on Slack if people can help us with the translations.. I think we have all nationalities covered. Jaime can do Spanish, I believe Stefan speaks French.. And I'm pretty sure we have Italians there too. |
Sorry, I only now see your comment, but either way I would be surprised if someone really tackles with that... |
|
I now see all translations as expected... Previously I've messed up my installation... |
d40033a to
9aa1d3f
Compare
9aa1d3f to
66f9fce
Compare
|
I've added back es, fr and it langs, but as empty translations, so if you ever decide to call for help on those translations, they will have their placeholders... |
I've gone through translations for existing languages and updated them. I've used Google Translate so I expect it to have (a lot of) inadequate or too literal translations. But since we have those languages from the beginning, I thought it might be valuable to have them even in that form...