Skip to content

Conversation

@cicnavi
Copy link
Collaborator

@cicnavi cicnavi commented Feb 9, 2025

I've gone through translations for existing languages and updated them. I've used Google Translate so I expect it to have (a lot of) inadequate or too literal translations. But since we have those languages from the beginning, I thought it might be valuable to have them even in that form...

@cicnavi cicnavi requested a review from tvdijen February 9, 2025 16:10
@codecov
Copy link

codecov bot commented Feb 9, 2025

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.

Project coverage is 52.66%. Comparing base (d3cdf5f) to head (5a18db6).
Report is 1 commits behind head on wip-version-6.

Files with missing lines Patch % Lines
src/Services/Container.php 0.00% 4 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##             wip-version-6     #285      +/-   ##
===================================================
+ Coverage            52.53%   52.66%   +0.13%     
  Complexity            1463     1463              
===================================================
  Files                  140      140              
  Lines                 6358     6361       +3     
===================================================
+ Hits                  3340     3350      +10     
+ Misses                3018     3011       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tvdijen
Copy link
Member

tvdijen commented Feb 11, 2025

I'm not sure this is a good idea.. The Dutch translations were pretty bad.. Some technical phrases are better left in English because they just don't translate well.

@cicnavi
Copy link
Collaborator Author

cicnavi commented Feb 11, 2025

Thanks for the input, I was afraid of that... So this presents maintenance burden, and also I don't really know which translation is ok and which is not ok... If I leave only old translations (and fallback to en for new ones), only like 10 % will be actually translated... So, I'm better of removing those languages totally. If someone wants them, we can add them at any time.

@tvdijen
Copy link
Member

tvdijen commented Feb 11, 2025

Nah, we just gotta ask on Slack if people can help us with the translations.. I think we have all nationalities covered. Jaime can do Spanish, I believe Stefan speaks French.. And I'm pretty sure we have Italians there too.

@cicnavi
Copy link
Collaborator Author

cicnavi commented Feb 11, 2025

Nah, we just gotta ask on Slack if people can help us with the translations.. I think we have all nationalities covered. Jaime can do Spanish, I believe Stefan speaks French.. And I'm pretty sure we have Italians there too.

Sorry, I only now see your comment, but either way I would be surprised if someone really tackles with that...

@cicnavi
Copy link
Collaborator Author

cicnavi commented Feb 11, 2025

I now see all translations as expected... Previously I've messed up my installation...

@cicnavi cicnavi force-pushed the wip-version-6-locales branch from d40033a to 9aa1d3f Compare February 11, 2025 21:53
@cicnavi cicnavi force-pushed the wip-version-6-locales branch from 9aa1d3f to 66f9fce Compare February 11, 2025 21:57
@cicnavi
Copy link
Collaborator Author

cicnavi commented Feb 12, 2025

I've added back es, fr and it langs, but as empty translations, so if you ever decide to call for help on those translations, they will have their placeholders...

@cicnavi cicnavi merged commit 5120124 into wip-version-6 Feb 12, 2025
14 checks passed
@cicnavi cicnavi deleted the wip-version-6-locales branch February 12, 2025 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants